Skip to content

test(web): steady the room-pills and panel-swipe tests on busy CI machines - #1029

Merged
badcuban merged 2 commits into
mainfrom
fix/flaky-room-pills-panel-swipe
Nov 20, 2026
Merged

badcuban merged 2 commits into
mainfrom
fix/flaky-room-pills-panel-swipe

Conversation

@badcuban

Copy link
Copy Markdown
Collaborator

Two browser tests kept failing intermittently on CI and in the merge queue (#1010 and #1026 both bounced on them), and they fail on main too.

Room pills ("picks who a room message goes to from the agent pills"): when the model picker opens or re-renders, it focuses its search box, then once more a frame later and once more on the next tick. On a busy CI machine those last two tries ran after the test had focused a pill, so the arrow key went to the search box. Reproduced exactly by holding those tries until after the pill was focused. The test now lets them pass first: two frames and a zero timeout. That's enough because the browser runs frame callbacks and equal timers in the order they were scheduled. The app keeps its retries, since they're what take focus back from the message box after /model.

Panel swipe ("closes the overlay panel with a finger pushing it right"): the swipe looked up the agents panel before the tab reorder above it had finished re-rendering, so on a busy machine the gesture could land on a replaced element or a covered spot. The test now waits until the element really under the finger is inside the agents panel, then starts the swipe on that element. If it still doesn't close, the failure message says what it found. This one never reproduced locally under CPU throttling, a page-thread hog, or 8 copies at once under load, so the cause is inferred.

Test files only. The full web browser suite passes (1,158 tests).

…hines

The room-pills test focused a pill while the model picker's last search-box
focus retries (one frame, one tick) were still pending; on a busy machine
they ran after and took the arrow key. It now lets them pass first.
Reproduced by holding those retries until after the pill was focused.

The panel-swipe test swiped an element it had looked up before the tab
reorder above finished re-rendering. It now swipes the panel as it is just
then, once the point under the finger is the panel's, and names what it
found if the swipe still doesn't close it. Not reproduced locally; inferred.
A missing hit passed the check, and the gesture went to the panel by
reference. The element under the finger must now be inside the agents
panel, and the swipe starts on it.
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
threadlines Skipped Skipped Nov 20, 2026 9:41pm UTC

Request Review

@badcuban
badcuban added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit 29c6292 Nov 20, 2026
23 checks passed
@badcuban
badcuban deleted the fix/flaky-room-pills-panel-swipe branch November 20, 2026 21:54

This branch was previously deployed

1 inactive deployment
Preview — 33a2b42e Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant